Bug 274154
| Summary: | [Win] Switch from MASM to clang-cl for assembling offlineasm | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ian Grunert <ian.grunert> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | Hironori.Fujii, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Windows 10 | ||
Ian Grunert
This brings Windows in line with every other platform in how they build offlineasm using the LLIntAssembly.h output.
After this change we can rip out the intel syntax generation from offlineasm x86.rb, as clang-cl inline asm supports AT&T syntax.
I also wonder if it'll open up possibility for ENABLE_UNIFIED_AND_FREEZABLE_CONFIG_RECORD, as the C++ compiler might be able to resolve the DLL bindings for offlineasm automatically (see this comment https://github.com/WebKit/WebKit/blob/b20a04aa7b405aaf02cebbda8fa73e51e32b1db8/Source/WTF/wtf/PlatformEnable.h#L856-L867)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ian Grunert
Pull request: https://github.com/WebKit/WebKit/pull/28538
EWS
Committed 278767@main (45da61538271): <https://commits.webkit.org/278767@main>
Reviewed commits have been landed. Closing PR #28538 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/128071085>