Bug 27415

Summary:

[V8] Phase 2: Remove event listener methods from V8Proxy

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Evangelism

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, fishd

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	none
patch	levin: review+

Adam Barth

Reported 2009-07-18 10:23:38 PDT

Now that all the event listener list logic has been removed from V8Proxy, we can remove the API and let clients talk to the lists directly.

Attachments
patch (18.80 KB, patch) 2009-07-18 10:25 PDT, Adam Barth	no flags	Details Formatted Diff Diff
patch (18.82 KB, patch) 2009-07-18 10:31 PDT, Adam Barth	levin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-07-18 10:25:50 PDT

Created attachment 33027 [details] patch

Adam Barth

Comment 2 2009-07-18 10:31:28 PDT

Created attachment 33028 [details] patch

David Levin

Comment 3 2009-07-19 00:16:22 PDT

Comment on attachment 33028 [details] patch Looks like a pretty mechanical change and the mechanics look correct.

Adam Barth

Comment 4 2009-07-19 00:39:12 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/V8ObjectEventListener.cpp M WebCore/bindings/v8/V8Proxy.cpp M WebCore/bindings/v8/V8Proxy.h M WebCore/bindings/v8/custom/V8AbstractWorkerCustom.cpp M WebCore/bindings/v8/custom/V8CustomEventListener.cpp M WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp M WebCore/bindings/v8/custom/V8ElementCustom.cpp M WebCore/bindings/v8/custom/V8MessagePortCustom.cpp M WebCore/bindings/v8/custom/V8NodeCustom.cpp M WebCore/bindings/v8/custom/V8SVGElementInstanceCustom.cpp M WebCore/bindings/v8/custom/V8WorkerCustom.cpp M WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp M WebCore/bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp Committed r46102 M WebCore/ChangeLog M WebCore/bindings/v8/V8Proxy.h M WebCore/bindings/v8/V8ObjectEventListener.cpp M WebCore/bindings/v8/V8Proxy.cpp M WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp M WebCore/bindings/v8/custom/V8WorkerCustom.cpp M WebCore/bindings/v8/custom/V8NodeCustom.cpp M WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp M WebCore/bindings/v8/custom/V8ElementCustom.cpp M WebCore/bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp M WebCore/bindings/v8/custom/V8CustomEventListener.cpp M WebCore/bindings/v8/custom/V8MessagePortCustom.cpp M WebCore/bindings/v8/custom/V8AbstractWorkerCustom.cpp M WebCore/bindings/v8/custom/V8SVGElementInstanceCustom.cpp r46102 = 29bb1e81e533faab62dd627defd6b4343f9c9179 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46102

Note You need to log in before you can comment on or make changes to this bug.