Bug 274108

Summary: [Remote Inspection] AX: Add screen reader support for targeted elements
Product: WebKit Reporter: Joshua Hoffman <jhoffman23>
Component: AccessibilityAssignee: Joshua Hoffman <jhoffman23>
Status: RESOLVED FIXED    
Severity: Normal CC: andresg_22, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Hoffman
Reported 2024-05-13 12:57:22 PDT
...
Attachments
Patch (10.99 KB, patch)
2024-05-13 13:05 PDT, Joshua Hoffman 		no flags
DetailsFormatted DiffDiff
Patch (11.23 KB, patch)
2024-05-13 14:27 PDT, Joshua Hoffman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-05-13 12:57:33 PDT
<rdar://problem/128019306>
Joshua Hoffman
Comment 2 2024-05-13 12:57:44 PDT
rdar://128019127
Joshua Hoffman
Comment 3 2024-05-13 13:05:33 PDT
Created attachment 471394 [details] Patch
Wenson Hsieh
Comment 4 2024-05-13 13:38:37 PDT
Comment on attachment 471394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471394&action=review > Source/WebCore/page/text-extraction/TextExtraction.cpp:469 > +static void extractRenderedText(Vector<StringsAndBlockOffset>& stringsAndOffsets, ContainerNode& node, BlockFlowDirection direction, bool shouldIncludeGeometry) Nit - maybe make this an `enum class : bool`?
Joshua Hoffman
Comment 5 2024-05-13 14:27:31 PDT
Created attachment 471395 [details] Patch
Joshua Hoffman
Comment 6 2024-05-13 14:28:05 PDT
Comment on attachment 471394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471394&action=review >> Source/WebCore/page/text-extraction/TextExtraction.cpp:469 >> +static void extractRenderedText(Vector<StringsAndBlockOffset>& stringsAndOffsets, ContainerNode& node, BlockFlowDirection direction, bool shouldIncludeGeometry) > > Nit - maybe make this an `enum class : bool`? Updated!
Joshua Hoffman
Comment 7 2024-05-13 14:28:14 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=471394&action=review >> Source/WebCore/page/text-extraction/TextExtraction.cpp:469 >> +static void extractRenderedText(Vector<StringsAndBlockOffset>& stringsAndOffsets, ContainerNode& node, BlockFlowDirection direction, bool shouldIncludeGeometry) > > Nit - maybe make this an `enum class : bool`? Updated!
EWS
Comment 8 2024-05-14 14:35:41 PDT
Committed 278780@main (ab68b25713f7): <https://commits.webkit.org/278780@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471395 [details].
Note You need to log in before you can comment on or make changes to this bug.