Bug 273934

Summary: Remove use of `webkitConvertPointFromNodeToPage` from GradientSlider.js
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Web InspectorAssignee: Ahmad Saleem <ahmad.saleem792>
Status: RESOLVED FIXED    
Severity: Normal CC: inspector-bugzilla-changes, qianlangchen, rcaliman, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Ahmad Saleem
Reported 2024-05-09 04:02:38 PDT
Hi Team, Creating it separate of bug 273734 to track the usage of 'webkitConvertPointFromNodeToPage' and figure out on how to remove this properly without regressing anything. Webkit Source: https://searchfox.org/wubkat/rev/7bf250e4832adfb28c2bf2bc518ad59958f2ae1b/Source/WebInspectorUI/UserInterface/Views/GradientSlider.js#404 ``` var translationFromParentToBody = window.webkitConvertPointFromNodeToPage(this.element.parentNode, new WebKitPoint(0, 0)); ``` Just raising, so we can track it. Thanks!
Attachments
Radar WebKit Bug Importer
Comment 1 2024-05-16 04:03:14 PDT
Ahmad Saleem
Comment 2 2024-09-01 05:10:08 PDT
Something along those lines: var parentRect = this.element.parentNode.getBoundingClientRect(); var translationFromParentToBody = { x: parentRect.left + window.pageXOffset, y: parentRect.top + window.pageYOffset };
Ahmad Saleem
Comment 3 2025-04-25 14:25:59 PDT
EWS
Comment 4 2025-04-28 06:00:32 PDT
Committed 294187@main (b26bed85494f): <https://commits.webkit.org/294187@main> Reviewed commits have been landed. Closing PR #44534 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.