Bug 273934
| Summary: | Remove use of `webkitConvertPointFromNodeToPage` from GradientSlider.js | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Web Inspector | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, qianlangchen, rcaliman, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
Creating it separate of bug 273734 to track the usage of 'webkitConvertPointFromNodeToPage' and figure out on how to remove this properly without regressing anything.
Webkit Source: https://searchfox.org/wubkat/rev/7bf250e4832adfb28c2bf2bc518ad59958f2ae1b/Source/WebInspectorUI/UserInterface/Views/GradientSlider.js#404
```
var translationFromParentToBody = window.webkitConvertPointFromNodeToPage(this.element.parentNode, new WebKitPoint(0, 0));
```
Just raising, so we can track it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/128188982>
Ahmad Saleem
Something along those lines:
var parentRect = this.element.parentNode.getBoundingClientRect();
var translationFromParentToBody = {
x: parentRect.left + window.pageXOffset,
y: parentRect.top + window.pageYOffset
};
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/44534
EWS
Committed 294187@main (b26bed85494f): <https://commits.webkit.org/294187@main>
Reviewed commits have been landed. Closing PR #44534 and removing active labels.