Bug 273898

Summary: [Cleanup] Remove RenderBox::hasOverridingLogicalHeightLength
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch ews-feeder: commit-queue-

alan
Reported 2024-05-08 13:55:01 PDT
ssia
Attachments
Patch (4.99 KB, patch)
2024-05-08 14:17 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (4.87 KB, patch)
2024-05-09 10:56 PDT, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-05-08 14:17:44 PDT
Created attachment 471325 [details] Patch
Simon Fraser (smfr)
Comment 2 2024-05-08 15:04:45 PDT
Comment on attachment 471325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471325&action=review > Source/WebCore/rendering/RenderBox.cpp:1414 > + return iterator != gOverridingLogicalHeightLengthMap->end() ? std::make_optional(iterator->value) : std::nullopt; Use getOptional()
alan
Comment 3 2024-05-09 10:56:43 PDT
Created attachment 471342 [details] [fast-cq]Patch
EWS
Comment 4 2024-05-09 12:52:59 PDT
Committed 278582@main (3b2509010ca2): <https://commits.webkit.org/278582@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471342 [details].
Radar WebKit Bug Importer
Comment 5 2024-05-09 12:53:29 PDT
<rdar://problem/127833243>
Note You need to log in before you can comment on or make changes to this bug.