Bug 273885

Summary: [Cleanup] Remove RenderBox::hasOverridingLogicalHeight
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2024-05-08 10:59:45 PDT
ssia
Attachments
Patch (31.90 KB, patch)
2024-05-08 11:25 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (31.23 KB, patch)
2024-05-08 13:08 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (31.11 KB, patch)
2024-05-08 20:08 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-05-08 11:25:50 PDT
Created attachment 471318 [details] Patch
alan
Comment 2 2024-05-08 13:08:47 PDT
Created attachment 471321 [details] Patch
Simon Fraser (smfr)
Comment 3 2024-05-08 15:04:04 PDT
Comment on attachment 471321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471321&action=review > Source/WebCore/rendering/RenderBox.cpp:1321 > + auto iterator = gOverridingLogicalHeightMap->find(*this); Use getOptional()
alan
Comment 4 2024-05-08 20:08:00 PDT
Created attachment 471331 [details] [fast-cq]Patch
EWS
Comment 5 2024-05-09 05:06:40 PDT
Committed 278557@main (6330fd99ca44): <https://commits.webkit.org/278557@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471331 [details].
Radar WebKit Bug Importer
Comment 6 2024-05-09 05:07:16 PDT
<rdar://problem/127806050>
Note You need to log in before you can comment on or make changes to this bug.