Bug 27387

Summary:

Implement ErrorEvent API.

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore JavaScript

Assignee:

Jian Li <jianli>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	eric: review-
Proposed Patch	eric: review+

Jian Li

Reported 2009-07-17 14:20:10 PDT

Implement ErrorEvent API as defined in http://www.whatwg.org/specs/web-workers/current-work/#runtime-script-errors.

Attachments
Proposed Patch (36.14 KB, patch) 2009-07-17 14:29 PDT, Jian Li	eric: review-	Details Formatted Diff Diff
Proposed Patch (36.04 KB, patch) 2009-07-20 17:26 PDT, Jian Li	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jian Li

Comment 1 2009-07-17 14:29:33 PDT

Created attachment 32971 [details] Proposed Patch

Eric Seidel (no email)

Comment 2 2009-07-20 15:22:34 PDT

Comment on attachment 32971 [details] Proposed Patch It seems this is not used yet. Shouldn't this be wrapped in the same ENABLE(WORKERS) liek the rest of workers?

Jian Li

Comment 3 2009-07-20 17:26:29 PDT

Created attachment 33125 [details] Proposed Patch I've wrapped the code in ENABLE(WORKERS). ErrorEvent will be used in the incoming patch I am going to submit for review.

Eric Seidel (no email)

Comment 4 2009-07-20 17:53:24 PDT

Comment on attachment 33125 [details] Proposed Patch LGTM.

Jian Li

Comment 5 2009-07-21 10:35:46 PDT

Committed as http://trac.webkit.org/changeset/46179

Note You need to log in before you can comment on or make changes to this bug.