Bug 273808
| Summary: | [RenderObject] logging to stderr by fprintf doesn't work on Windows Debug Console | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kohei Asano <kohei.asano> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | CC: | fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | PC | ||
| OS: | Windows 10 | ||
Kohei Asano
RenderingObject logging utils emit parts of info to stderr, as we see https://github.com/WebKit/WebKit/blob/main/Source/WebCore/rendering/RenderObject.cpp#L2736-L2761 . This doesn't work well on Windows, and platform independent logging should have used WTFLogAlways instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kohei Asano
Here is permalink to the corresponding sources https://github.com/WebKit/WebKit/blob/8d2e51d04796823702b47e48943d3dd735d67eae/Source/WebCore/rendering/RenderObject.cpp#L2736-L2761 .
Kohei Asano
Pull request: https://github.com/WebKit/WebKit/pull/28224
EWS
Committed 278532@main (63eb3f6b9a35): <https://commits.webkit.org/278532@main>
Reviewed commits have been landed. Closing PR #28224 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/127768950>