Bug 273672

Summary:	Rename "computedCSSPadding()" to "resolveLengthPercentageUsingContainerLogicalWidth()"
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Layout and Rendering	Assignee:	Simon Fraser (smfr) <simon.fraser>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Simon Fraser (smfr)

Reported 2024-05-02 21:15:43 PDT

"computedCSSPadding()" is called with margin values in RenderBox::marginBoxRect(), so the new name makes more sense, since it's resolving CSS <length-percentage> values: https://drafts.csswg.org/css-values-4/#mixed-percentages

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-05-02 21:19:48 PDT

<rdar://problem/127473476>

Simon Fraser (smfr)

Comment 2 2024-05-02 21:20:21 PDT

Pull request: https://github.com/WebKit/WebKit/pull/28082

EWS

Comment 3 2024-05-03 12:12:24 PDT

Committed 278335@main (4142d950a6e7): <https://commits.webkit.org/278335@main> Reviewed commits have been landed. Closing PR #28082 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.