Bug 27359

Summary:

[V8] Centralize hidden property names

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

WebCore JavaScript

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	levin: review+

Adam Barth

Reported 2009-07-16 18:46:14 PDT

We should centralize our repository of hidden property names so we don't step on each others toes in the bindings layer. Patch forth coming.

Attachments
patch (10.12 KB, patch) 2009-07-16 18:47 PDT, Adam Barth	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-07-16 18:47:55 PDT

Created attachment 32910 [details] patch

David Levin

Comment 2 2009-07-16 19:07:46 PDT

Comment on attachment 32910 [details] patch > Index: WebCore/bindings/v8/V8HiddenPropertyName.cpp > + static v8::Persistent<v8::String>* string = new v8::Persistent<v8::String>(v8::Persistent<v8::String>::New(v8::String::NewSymbol(key))); It seems a shame to repeat "new v8::Persistent<v8::String>(v8::Persistent<v8::String>::New(v8::String::NewSymbol(key)))" twice already in this file. What about a function so this line of code would look something like this static v8::Persistent<v8::String>* string = createV8PeristentString(key) ?

Adam Barth

Comment 3 2009-07-16 21:18:07 PDT

Will land with modifications.

Adam Barth

Comment 4 2009-07-16 21:29:12 PDT

http://trac.webkit.org/changeset/46005

Note You need to log in before you can comment on or make changes to this bug.