Bug 27358

Summary: [Qt] Fix the include path for the Symbian port
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, norbert.leser, yongjun.zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
Proposed fix. hausmann: review+

Laszlo Gombos
Reported 2009-07-16 17:16:01 PDT
Some number of Symbian system headers have the same name as headers in WebCore\JavaScriptCore (e.g. Profiler.h, Event.h, Base64.h, File.h). Currently system headers are included before WebCore\JavaScriptCore headers in the Qt build system, which leads to a build break on Symbian.
Attachments
Proposed fix. (5.62 KB, patch)
2009-07-16 17:36 PDT, Laszlo Gombos 		hausmann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2009-07-16 17:36:29 PDT
Created attachment 32907 [details] Proposed fix. Started as a build fix; ended up being a lot of cleanup. This patch puts the system includes at the end of the include path, so that when the include path is built up new (more specific) path elements are prepended (and not appended) to the include path. For example the include path for WebCore looks like this: - Qt port specific dirs - Port independent WebCore dirs - JavaScriptCore dirs - System includes. In addition the patch includes the following cleanups: - Sorted the include lists - Fixed the Qt port specific include list (so that it only includes Qt port specific dirs and it includes all of those) - Removed WebCore/ForwardingHeaders from WebCore include path (as JavaScriptCore.pri is included). This should make the build a bit faster. Tested on Linux/Windows/Symbian.
Simon Hausmann
Comment 2 2009-07-17 06:55:51 PDT
Comment on attachment 32907 [details] Proposed fix. r=me. Nice!
Simon Hausmann
Comment 3 2009-07-17 06:56:55 PDT
Landed in r46032
Norbert Leser
Comment 4 2009-08-06 12:18:12 PDT
*** Bug 27061 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.