Bug 273569
| Summary: | Added a compile time assertion that forbids classes that offer WeakPtr with no corresponding RefPtr or CheckedPtr | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> |
| Component: | DOM | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Geoffrey Garen
https://github.com/WebKit/WebKit/pull/27847
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
<rdar://problem/127296969>
Geoffrey Garen
Pull request: https://github.com/WebKit/WebKit/pull/27847
EWS
Committed 278224@main (c13321a96e1d): <https://commits.webkit.org/278224@main>
Reviewed commits have been landed. Closing PR #27847 and removing active labels.
Diego Pino
After this patch, the GTK-Linux-64-bit-Release-Clang-Build bot is failing with the followin build error:
https://build.webkit.org/#/builders/629/builds/11538
```
In file included from /app/webkit/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h:29:
/app/webkit/Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h:47:33: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'?
using WeakPtrSecKeyProxyStore = nullptr_t;
^~~~~~~~~
std::nullptr_t
/usr/lib/gcc/x86_64-unknown-linux-gnu/13.2.0/../../../../include/c++/13.2.0/x86_64-unknown-linux-gnu/bits/c++config.h:312:29: note: 'std::nullptr_t' declared here
typedef decltype(nullptr) nullptr_t;
^
1 error generated.
```
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/28034
EWS
Committed 278246@main (514a7d938a6c): <https://commits.webkit.org/278246@main>
Reviewed commits have been landed. Closing PR #28034 and removing active labels.