Bug 273493 – Regression(278060@main): build error with ENABLE_RELEASE_LOG=OFF and ENABLE_JOURNALD_LOG=OFF

• Component: New Bugs
• Status: RESOLVED FIXED

[Przemyslaw Gorszkowski]

/app/webkit/Source/WebCore/Modules/mediasource/MediaSource.cpp:1484:43: error: unused parameter ‘time’ [-Werror=unused-parameter]
 1484 | void MediaSource::seeked(const MediaTime& time)
      |                          ~~~~~~~~~~~~~~~~~^~~~
cc1plus: all warnings being treated as errors

It seems that ALWAYS_LOG does not always log if ENABLE_RELEASE_LOG=OFF and ENABLE_JOURNALD_LOG=OFF and USE_OS_LOG=OFF

void MediaSource::seeked(const MediaTime& time)
{
    ALWAYS_LOG(LOGIDENTIFIER, time);
    monitorSourceBuffers();
}


#if ENABLE(RELEASE_LOG)
#define RELEASE_LOG_DISABLED 0
#else
#define RELEASE_LOG_DISABLED !(USE(OS_LOG) || ENABLE(JOURNALD_LOG))
#endif

dummy/empty ALWAYS_LOG:
https://github.com/WebKit/WebKit/blob/main/Source/WTF/wtf/LoggerHelper.h#L100

[Przemyslaw Gorszkowski]

Pull request: https://github.com/WebKit/WebKit/pull/27932

[EWS]

Committed 278207@main (989aca0e762e): <https://commits.webkit.org/278207@main>

Reviewed commits have been landed. Closing PR #27932 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/127352547>