[GTK] Change the focus-in/grab-focus code to set FocusController::setFocusedFrame

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Holger Freyther]

We need to set the FocusController::setFocusedFrame if currently no focused frame is set. This is important for some events and will become very important once we look and probably fix bugs in the tab focus handling.

[Holger Freyther]

Created attachment 32863 [details]
[GTK+] Make TestNescpaePlugin loadable in mozilla

Currently the NPNetscapeFuncs of WebKit contains two more
entries than the gecko version. This means comparing the
aMozillaVTable->size with the size of NPNetscpaeFuncs will
fail and the plugin will not be loaded.

For testing it is nice to be able to load the plugin into
gecko and currently we are not using the two extra methods.
Remove the test to be able to use the plugin in gecko.
---
 2 files changed, 13 insertions(+), 2 deletions(-)

[Jan Alonzo]

(In reply to comment #1)
> Created an attachment (id=32863) [details]
> [GTK+] Make TestNescpaePlugin loadable in mozilla
> 
> Currently the NPNetscapeFuncs of WebKit contains two more
> entries than the gecko version. This means comparing the
> aMozillaVTable->size with the size of NPNetscpaeFuncs will
> fail and the plugin will not be loaded.
> 
> For testing it is nice to be able to load the plugin into
> gecko and currently we are not using the two extra methods.
> Remove the test to be able to use the plugin in gecko.
> ---
>  2 files changed, 13 insertions(+), 2 deletions(-)

Hi Holger. Are you sure this is the correct bug for this patch?

[Holger Freyther]

Created attachment 32865 [details]
[GTK+] Update the focus handling code.

Make sure to call FocusController::setFocusedFrame when
we didn't set a focused frame yet. We are doing this in
the grab-focus and focus-in routine.
---
 2 files changed, 30 insertions(+), 3 deletions(-)

[Jan Alonzo]

Comment on attachment 32865 [details]
[GTK+] Update the focus handling code.

r=me.

[Adam Barth]

Will land.

[Adam Barth]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/gtk/ChangeLog
	M	WebKit/gtk/webkit/webkitwebview.cpp
Committed r46007
	M	WebKit/gtk/webkit/webkitwebview.cpp
	M	WebKit/gtk/ChangeLog
r46007 = 8466b2eedf7b7d67bab2051631e57b598b61565e (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46007