Bug 27341

Summary: cpplint should flag usages of NULL.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Enhancement CC: hamaji
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed fix.
none
Proposed fix. manyoso: review+

David Levin
Reported 2009-07-16 02:55:21 PDT
According to http://webkit.org/coding/coding-style.html "In C++, the null pointer value should be written as 0. In C, it should be written as NULL. In Objective-C and Objective-C++, follow the guideline for C or C++, respectively, but use nil to represent a null Objective-C object."
Attachments
Proposed fix. (8.71 KB, patch)
2009-07-17 04:45 PDT, David Levin 		no flags
DetailsFormatted DiffDiff
Proposed fix. (8.68 KB, patch)
2009-07-17 04:48 PDT, David Levin 		manyoso: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-07-17 04:45:09 PDT
Created attachment 32928 [details] Proposed fix.
David Levin
Comment 2 2009-07-17 04:48:57 PDT
Created attachment 32929 [details] Proposed fix.
Adam Treat
Comment 3 2009-07-17 10:46:07 PDT
Comment on attachment 32929 [details] Proposed fix. Awesome! I was planning on writing this one later :)
David Levin
Comment 4 2009-07-17 14:25:02 PDT
Committed as http://trac.webkit.org/changeset/46047
Note You need to log in before you can comment on or make changes to this bug.