Bug 273249

Summary: AX: Refactor the implementation of the NSAccessibilityChildrenAttribute API to avoid recursive calss.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2024-04-25 08:57:39 PDT
.
Attachments
Patch (17.49 KB, patch)
2024-04-25 08:59 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (17.50 KB, patch)
2024-04-25 18:32 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-04-25 08:57:49 PDT
<rdar://problem/127053935>
Andres Gonzalez
Comment 2 2024-04-25 08:59:47 PDT
Created attachment 471128 [details] Patch
Tyler Wilcock
Comment 3 2024-04-25 09:17:49 PDT
Comment on attachment 471128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471128&action=review > COMMIT_MESSAGE:7 > +Recursive calls to [WebAccessibilityObjectWrapper accessibilityAttributeValue:] has a performance impact since will do a liear search in the attribute name in each frame, plus call to update the backing store, create a new RefPtr for the backing object, etc. This patch resolves this problem for the NSAccessibilityChildrenAttribute API by creating the children() helper function and calling it instead. Includes related code cleanup. Some typos here, but not a big deal. "liear" vs. "linear", "has" vs. "have", probably a missing word between "since" and "will"
Andres Gonzalez
Comment 4 2024-04-25 18:32:39 PDT
Created attachment 471150 [details] Patch
EWS
Comment 5 2024-04-25 20:13:54 PDT
Committed 278025@main (3831bd503255): <https://commits.webkit.org/278025@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471150 [details].
Note You need to log in before you can comment on or make changes to this bug.