Bug 27316 – [Qt] more than 100 tests in Qt's DRT Skipped list works for me

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Kenneth Rohde Christiansen]

More than 100 tests in Qt's DRT Skipped list works for me. If other can confirm the same we can remove them from the Skipped list.

[Kenneth Rohde Christiansen]

Created attachment 32808 [details]
Lists of tests in the Qt Skipped list that works for me on Linux 64 Bit

[Kenneth Rohde Christiansen]

Created attachment 32816 [details]
Remove tests from Qt Skipped list that are actually working.

[Kenneth Rohde Christiansen]

My current output:

4973 test cases (98%) succeeded
11 test cases (<1%) had incorrect layout
44 test cases (<1%) were new
2 test cases (<1%) timed out
11 test cases (<1%) crashed
1 test case (<1%) had stderr output

This is the same as earlier today just with 4973 tests succeeded in comparison with 4883 earlier.

[Oliver Hunt]

Comment on attachment 32816 [details]
Remove tests from Qt Skipped list that are actually working.

r=me

[Antonio Gomes]

i tried to validate the patch in a 32-bit linux box (since patch was tested on a 64bit machine and results can vary), but it does not apply cleanly to ToT, sorry ...

patch -p1 < ../skipped_list.patch
patching file LayoutTests/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/ChangeLog.rej
patching file LayoutTests/platform/qt/Skipped
Hunk #5 succeeded at 127 (offset 1 line).
Hunk #6 succeeded at 196 (offset 1 line).
Hunk #7 succeeded at 282 (offset 1 line).
Hunk #8 succeeded at 416 (offset 1 line).
Hunk #9 succeeded at 629 (offset 1 line).
Hunk #10 succeeded at 758 (offset 1 line).
Hunk #11 succeeded at 846 (offset 1 line).
Hunk #12 succeeded at 868 (offset 1 line).
Hunk #13 succeeded at 896 (offset 1 line).
Hunk #14 succeeded at 960 (offset 1 line).
Hunk #15 succeeded at 1010 (offset 1 line).
Hunk #16 succeeded at 1037 (offset 1 line).
Hunk #17 succeeded at 1698 (offset 1 line).
Hunk #18 succeeded at 1708 (offset 1 line).
Hunk #19 succeeded at 1851 (offset 1 line).
Hunk #20 succeeded at 1878 (offset 1 line).
Hunk #21 succeeded at 1889 (offset 1 line).
Hunk #22 succeeded at 2901 (offset 1 line).
Hunk #23 succeeded at 2951 (offset 1 line).
Hunk #24 succeeded at 3011 (offset 1 line).
Hunk #25 succeeded at 3123 (offset 1 line).
Hunk #26 succeeded at 4985 (offset 1 line).
Hunk #27 succeeded at 5042 (offset 1 line).
Hunk #28 succeeded at 5059 (offset 1 line).
Hunk #29 succeeded at 5071 (offset 1 line).
Hunk #30 FAILED at 5079.
1 out of 30 hunks FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej

[Adam Barth]

Comment on attachment 32816 [details]
Remove tests from Qt Skipped list that are actually working.

I confirm that this patch does not apply to TOT, which makes this patch not actionable.  Please upload a new version that applies cleanly.

[Kenneth Rohde Christiansen]

Created attachment 32938 [details]
Remove tests from Qt Skipped list that are actually working.

[Simon Hausmann]

Comment on attachment 32938 [details]
Remove tests from Qt Skipped list that are actually working.

r=me. thanks

[Simon Hausmann]

Landed in 46034