Bug 273153

Summary: NEW TEST (277392@main): [ MacOS x86_64 Debug ] TestWebKitAPI.WKWebExtensionDataRecord.RemoveDataRecords is a consistent crash
Product: WebKit Reporter: Jay Stfleur <j_stfleur>
Component: New BugsAssignee: Kiara Rose <kiara_rose>
Status: REOPENED ---    
Severity: Normal CC: ap, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Jay Stfleur 2024-04-23 16:45:13 PDT 
Description:
TestWebKitAPI.WKWebExtensionDataRecord.RemoveDataRecords 

Is a consistent crash with ( ASSERTION FAILED: Completion handler should always be called) on Monterey and Ventura x86_64 Debug after being enabled on 277392@main

Buildbot URL:
https://build.webkit.org/#/builders/944/builds/1459/steps/19/logs/stdio

History:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WKWebExtensionDataRecord.RemoveDataRecords&version_name=Monterey&version_name=Ventura&style=debug&architecture=x86_64&recent=false

Diff/Image Diff/Crash Log:

 ASSERTION FAILED: Completion handler should always be called
        !m_function
        /Volumes/Data/worker/Apple-Sonoma-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/CompletionHandler.h(66) : WTF::CompletionHandler<void (std::experimental::expected<void, WTF::String> &&)>::~CompletionHandler()
        1   0x119d76fb9 WTFCrash
        2   0x198c4acfc WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<void, WTF::String>&&)>::~CompletionHandler()
        3   0x198c40e05 WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<void, WTF::String>&&)>::~CompletionHandler()
        4   0x198e4f615 WebKit::WebExtensionController::removeStorage(_WKWebExtensionStorageSQLiteStore*, WebKit::WebExtensionDataType, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<void, WTF::String>&&)>&&)::$_4::~$_4()

        5   0x198e45045 WebKit::WebExtensionController::removeStorage(_WKWebExtensionStorageSQLiteStore*, WebKit::WebExtensionDataType, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<void, WTF::String>&&)>&&)::$_4::~$_4()

        6   0x198e4f41d WTF::BlockPtrArc<void (NSString*)> WTF::BlockPtrArc<void (NSString*)>::fromCallable<WebKit::WebExtensionController::removeStorage(_WKWebExtensionStorageSQLiteStore*, WebKit::WebExtensionDataType, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<void, WTF::String>&&)>&&)::$_4>(WebKit::WebExtensionController::removeStorage(_WKWebExtensionStorageSQLiteStore*, WebKit::WebExtensionDataType, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<void, WTF::String>&&)>&&)::$_4)::'lambda'(void const*)::operator()(void const*) const

        7   0x198e4f3d9 WTF::BlockPtrArc<void (NSString*)> WTF::BlockPtrArc<void (NSString*)>::fromCallable<WebKit::WebExtensionController::removeStorage(_WKWebExtensionStorageSQLiteStore*, WebKit::WebExtensionDataType, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<void, WTF::String>&&)>&&)::$_4>(WebKit::WebExtensionController::removeStorage(_WKWebExtensionStorageSQLiteStore*, WebKit::WebExtensionDataType, WTF::CompletionHandler<void (std::experimental::fundamentals_v3::expected<void, WTF::String>&&)>&&)::$_4)::'lambda'(void const*)::__invoke(void const*)
        8   0x7ff809d93726 _call_dispose_helpers_excp
        9   0x7ff809d93555 _Block_release
        10  0x195df7de1 __destroy_helper_block_ea8_32s40c56_ZTSN3WTF14WeakObjCPtrArcI26_WKWebExtensionSQLiteStoreEE
        11  0x7ff809d93726 _call_dispose_helpers_excp
        12  0x7ff809d93555 _Block_release
        13  0x7ff809ef1dbc _dispatch_client_callout
        14  0x7ff809ef7eff _dispatch_lane_serial_drain
        15  0x7ff809ef8997 _dispatch_lane_invoke
        16  0x7ff809f02414 _dispatch_root_queue_drain_deferred_wlh
        17  0x7ff809f01d2a _dispatch_workloop_worker_thread
        18  0x7ff80a08fb84 _pthread_wqthread
        19  0x7ff80a08eacf start_wqthread
Comment 1 Radar WebKit Bug Importer 2024-04-23 16:45:40 PDT 
<rdar://problem/126951537>
Comment 2 Alexey Proskuryakov 2024-04-24 08:52:28 PDT 
Should we just revert 277392@main, given that it didn't serve its main purpose of fixing the test?
Comment 3 Kiara Rose 2024-04-24 09:51:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/27699
Comment 4 EWS 2024-04-24 09:58:27 PDT 
Committed 277929@main (8ac73cce95be): <https://commits.webkit.org/277929@main>

Reviewed commits have been landed. Closing PR #27699 and removing active labels.
Comment 5 Alexey Proskuryakov 2024-04-24 10:28:03 PDT 
This change has disabled the test again, so re-opening to track that it's still failing.