Bug 273089

Summary: AX: Remove AccessibilityRole::ApplicationGroup and AccessibilityRole::ApplicationTextGroup to simplify group logic
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tyler Wilcock
Reported 2024-04-22 13:59:58 PDT
Currently, there are four "group" roles: Group, ApplicationGroup, TextGroup, ApplicationTextGroup. The original intention for separating these was that the Application style roles were explicitly defined by the author (e.g. via role="group" for ApplicationGroup and role="doc-example" for ApplicationTextGroup), while the non-Application variants were implicitly assigned via heuristics done by the user agent (WebKit). However, that distinction has become muddied over time: 1. To support Web Inspector and WPTs, AccessibilityRole::Group has (sometimes) become synonymous with "generic" (mostly because we used to assign this role to nearly every div on the page). This is confusing because it doesn't match or map to role="group" (which is AccessibilityRole::ApplicationGroup). 2. Partially due to point one, in several places we have started returning ApplicationGroup even when the element is not explicitly assigned as such (i.e. via role="group"), going against the point of this role's existence. It's confusing to have this many group-style roles. We should change this.
Attachments
Patch (36.66 KB, patch)
2024-04-22 14:05 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (38.59 KB, patch)
2024-04-22 17:36 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-04-22 14:00:11 PDT
<rdar://problem/126880483>
Tyler Wilcock
Comment 2 2024-04-22 14:05:08 PDT
Created attachment 471045 [details] Patch
Tyler Wilcock
Comment 3 2024-04-22 17:36:15 PDT
Created attachment 471054 [details] Patch
EWS
Comment 4 2024-04-23 14:54:30 PDT
Committed 277894@main (95019f166e2d): <https://commits.webkit.org/277894@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471054 [details].
Note You need to log in before you can comment on or make changes to this bug.