Bug 272896 – References to SharedArrayBuffer Retained Across Page Refresh

• Component: JavaScriptCore
• Status: REOPENED

[Tyler Gross]

Created attachment 470987 [details]
Heap showing two instances of retained SharedArrayBuffer

Memory continues to grow when you refresh the page in both Safari and STP in Photoshop Web.
When I inspect heap snapshots, it looks like the memory that's being retained is the actual SharedArrayBuffer from the previous instance of the app.

Steps to Reproduce:
1. Open photoshop.adobe.com/
2. Create a new document
3. Once the new document has loaded, open the JavaScript Allocations section under Timelines
4. Take a heap snapshot
5. Refresh the page
6. Wait for the document to load
7. Take another heap snapshot
8. Observe memory increase between snapshots
9. As the threshold of memory used nears 15GB, the app will eventually crash with "This webpage was reloaded because it was using significant memory"

Heap snapshot.

[Radar WebKit Bug Importer]

<rdar://problem/126690921>

[Tyler Gross]

Created attachment 470988 [details]
Heap snapshot baseline, no refreshes

[Tyler Gross]

Created attachment 470989 [details]
Heap snapshop 1 refresh

[Alexey Proskuryakov]

Thank you for the report. Do you happen to have a reduced test case?

[Tyler Gross]

A minimal repro can be found here: https://github.com/milky2028/safari-memory-leak

[Erik Schneider]

Hi Alexey, Now that Tyler's provided a reduced test case, is this something that can be investigated? For context, this bug is the main blocker for unlocking support for Photoshop Web on Safari.

[Yijia Huang]

Pull request: https://github.com/WebKit/WebKit/pull/29363

[EWS]

Committed 279852@main (1e4577ba8de4): <https://commits.webkit.org/279852@main>

Reviewed commits have been landed. Closing PR #29363 and removing active labels.

[Tyler Gross]

Tested in STP 198 and bug is not fixed with original reproduction example.

[Yijia Huang]

Sorry about that. Previously, I only checked and confirmed with mini repro case. 


This https://bugs.webkit.org/show_bug.cgi?id=276410 (https://commits.webkit.org/280830@main) should fix the memory issue. I've confirmed on both the mini repro case and website: https://photoshop.adobe.com/id?dpasset=https%3A%2F%2Fhelpx.adobe.com%2Fcontent%2Fdam%2Fhelp%2Fen%2Fphotoshop%2Fhow-to%2Fin-app%2Fget-started-photoshop-web%2FGet_Started.psd&dp_query=exp.campaign_id%3DCCH-HOT%26content.type%3DcmWebHandsOnTutorial%26content.id%3Dphotoshop%252Fhow-to%252Fin-app%252Fget-started-photoshop-web&flags=no_cchome_redirect%2Cdiscover_context%2Cdiscover_panel%26discover_mode%3Dtrue&lang=en&flag=no_browsercheck.

[Tyler Gross]

This issue persists. We have a second minimal repro that demonstrates crashing after refreshing with the "significant memory" error.

https://photoshop-web-no-ui.netlify.app/

Make sure to test in Safari 18.0.1 or later, as prior to that out of memory crashes will happen when the application starts.

[Yijia Huang]

<rdar://142387240>

[Yijia Huang]

We use this rdar://142387240 to track this memory leaking issue.