Summary: | Click/releases on scrollbars misbehave when mouse move is missed | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Viet-Trung Luu <viettrungluu> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, hyatt, manyoso | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | OS X 10.5 | ||||||||||||||
Attachments: |
|
Description
Viet-Trung Luu
2009-07-14 22:18:00 PDT
Created attachment 32769 [details] Fixes bug 27289 by updating m_lastScrollbarUnderMouse on mouse down. EventHandler::m_lastScrollbarUnderMouse is currently only updated on mouse move and not on mouse down, which makes it fail (or at least behave oddly) when a mouse down on a scrollbar occurs without a mouse move onto the scrollbar; this patch fixes this. Created attachment 32881 [details] Fixes bug 27289 (same as previous version of patch) and adds test cases. Created attachment 32882 [details] Patch and test cases for bug 27289. Got rid of duplicate Changelog entry. This bug drives me nuts. I think Hyatt is the expert on scrolling. Comment on attachment 32882 [details] Patch and test cases for bug 27289. One minor comment. You repeat the same if statement block twice. Can you make that into a helper function, e.g., something like updateLastScrollbarUnderMouse? Created attachment 33287 [details] Patch and test cases for bug 27289 Added a helper method to avoid repeating code. Comment on attachment 33287 [details] Patch and test cases for bug 27289 r=me |