Bug 27277

Summary: [V8] Fix isolated world wrappers for Node prototypes
Product: WebKit Reporter: Adam Barth <abarth>
Component: WebCore JavaScriptAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: aa, abarth, dglazkov, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch dglazkov: review+

Description Adam Barth 2009-07-14 15:38:12 PDT
The next step is to fix the prototype chains for node prototypes in isolated worlds.  Patch forthcoming.
Comment 1 Adam Barth 2009-07-14 15:48:59 PDT
Created attachment 32740 [details]
patch

Sorry for the goofy diff format.  I'm working out of an improvised git repo in my Chromium tree.
Comment 2 Adam Barth 2009-07-14 15:54:02 PDT
Created attachment 32741 [details]
patch

Oops.  The previous version was slightly old.
Comment 3 Dimitri Glazkov (Google) 2009-07-14 15:56:26 PDT
Comment on attachment 32741 [details]
patch

sounds good.
Comment 4 David Levin 2009-07-14 16:00:29 PDT
static v8::Handle<v8::Context> V8DOMWrapper::getWrapperContext(Frame* frame);

Not: Remove the param name "frame".
Comment 5 Adam Barth 2009-07-14 16:06:23 PDT
Assigning to myself for landing.
Comment 6 Adam Barth 2009-07-14 17:11:10 PDT
Sending        WebCore/ChangeLog
Sending        WebCore/bindings/v8/V8DOMWrapper.cpp
Sending        WebCore/bindings/v8/V8DOMWrapper.h
Transmitting file data ...
Committed revision 45884.
Comment 7 Dimitri Glazkov (Google) 2009-07-15 09:28:08 PDT
Fix landed as http://trac.webkit.org/changeset/45916.