Bug 27270

Summary:

The WebFormDelegate -(BOOL)textField:shouldHandleEvent:inFrame is never called

Product:

WebKit

Reporter:

Greg Bolsinga <bolsinga>

Component:

WebKit Misc.

Assignee:

Greg Bolsinga <bolsinga>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

adele, aroben, darin, ddkilzer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.5

Attachments:

Description	Flags
removes the unused delegate method	none
Remove the uncalled declaration for windows as well.	none

Greg Bolsinga

Reported 2009-07-14 12:14:57 PDT

It can be removed. <rdar://problem/7058089>

Attachments
removes the unused delegate method (2.62 KB, patch) 2009-07-14 13:22 PDT, Greg Bolsinga	no flags	Details Formatted Diff Diff
Remove the uncalled declaration for windows as well. (4.77 KB, patch) 2009-07-14 14:20 PDT, Greg Bolsinga	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Greg Bolsinga

Comment 1 2009-07-14 13:22:24 PDT

Created attachment 32731 [details] removes the unused delegate method This delegate is implemented in Safari, but not called anywhere.

Adele Peterson

Comment 2 2009-07-14 14:13:15 PDT

Comment on attachment 32731 [details] removes the unused delegate method What about on other platforms?

Greg Bolsinga

Comment 3 2009-07-14 14:20:10 PDT

Created attachment 32734 [details] Remove the uncalled declaration for windows as well. I do not see it called at all via grep for shouldHandleEvent in all of WebKit (after this new patch! ;)

Adam Roben (:aroben)

Comment 4 2009-07-14 14:40:26 PDT

Was this delegate method ever called? Would it still be useful to have it? Maybe the call to it was removed by mistake.

Greg Bolsinga

Comment 5 2009-07-14 14:43:09 PDT

Aha. This actually cannot be removed it seems.

Darin Adler

Comment 6 2009-07-14 14:53:39 PDT

(In reply to comment #5) > Aha. This actually cannot be removed it seems. What does this mysterious remark mean? The patch is still up for review.

Greg Bolsinga

Comment 7 2009-07-14 14:54:43 PDT

It means I didn't do the right thing, I guess. I did a search and wound up finding a user.

David Kilzer (:ddkilzer)

Comment 8 2009-07-14 15:25:41 PDT

(In reply to comment #7) > It means I didn't do the right thing, I guess. I did a search and wound up > finding a user. So this bug may be closed as RESOLVED/INVALID?

Eric Seidel (no email)

Comment 9 2009-07-15 16:06:52 PDT

Comment on attachment 32734 [details] Remove the uncalled declaration for windows as well. LGTM.

David Kilzer (:ddkilzer)

Comment 10 2009-07-15 16:30:34 PDT

Comment on attachment 32734 [details] Remove the uncalled declaration for windows as well. No, this patch should not be landed yet as there are still unanswered questions. I'm clearing the review flag until Greg returns from vacation.

Greg Bolsinga

Comment 11 2009-09-12 12:09:19 PDT

This bug is invalid.

Note You need to log in before you can comment on or make changes to this bug.