Bug 272599
| Summary: | [WebGPU] https://playcanvas.github.io/#/misc/spineboy fails because sampler is not compatible with sampler_comparison | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Wyrzykowski <mwyrzykowski> |
| Component: | WebGPU | Assignee: | Mike Wyrzykowski <mwyrzykowski> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mike Wyrzykowski
Repro:
Open https://playcanvas.github.io/#/misc/spineboy
Place a breakpoint in GlobalVariableRewriter.cpp:1486
static bool isSampler(const AST::Variable& variable, SamplerBindingType bindingType)
return bindingTypeForType(variable.storeType()) == BindingType::SamplerComparison;
fails because the storeType is a Sampler and not a SamplerComparison
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mike Wyrzykowski
the sampler which fails I think is:
@group(1) @binding(6) var shadowAtlasTexture_sampler : sampler;
which is not used anywhere from what I can tell in the WGSL source.
we are not considering the 'statically used' portion of the specification:
https://www.w3.org/TR/webgpu/#statically-used
Radar WebKit Bug Importer
<rdar://problem/126385846>
Mike Wyrzykowski
Pull request: https://github.com/WebKit/WebKit/pull/27211
EWS
Committed 277503@main (626da617fd7b): <https://commits.webkit.org/277503@main>
Reviewed commits have been landed. Closing PR #27211 and removing active labels.