Bug 27251

Summary: [Gtk] Remove hildon/maemo code
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED WONTFIX    
Severity: Normal CC: gustavo, lists, mrobinson, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Jan Alonzo
Reported 2009-07-14 03:38:46 PDT
AFAICT, the hildon/maemo code in the gtk port hasn't been touched by anyone since early last year. I'd like propose to remove the hildon/maemo code from the codebase.
Attachments
Patch (3.39 KB, patch)
2011-06-15 08:59 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thijs Triemstra
Comment 1 2010-08-26 05:43:32 PDT
It looks like it's also messing with the build (on osx 10.6.4). When I run: WebKitTools/Scripts/build-webkit --gtk --disable-video --with-hildon=no It dies with the following error: checking pthread.h usability... yes checking pthread.h presence... yes checking for pthread.h... yes checking for jpeg_destroy_decompress in -ljpeg... yes checking for jpeglib... yes checking for libpng... yes checking the GTK+ version to use... 2.0 checking the target windowing system... x11 checking for Hildon UI extensions... no ../../configure: line 18624: syntax error near unexpected token `HILDON,' ../../configure: line 18624: ` PKG_CHECK_MODULES(HILDON, hildon-1)' Failed to setup build environment using 'autotools'! Should I open a new ticket for this issue?
Martin Robinson
Comment 2 2011-06-15 08:59:03 PDT
Created attachment 97303 [details] Patch
Martin Robinson
Comment 3 2011-06-15 10:18:16 PDT
The consensus here is that: 1. We will not maintain the Hildon code. 2. We will not remove it until we remove GTK+ 2.x support.
Eric Seidel (no email)
Comment 4 2011-06-18 13:51:48 PDT
Comment on attachment 97303 [details] Patch Cleared review? from attachment 97303 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.