Bug 27242

Summary: JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 27133    
Bug Blocks: 27088    
Attachments:
Description Flags
patch mitz: review+

Eric Seidel (no email)
Reported 2009-07-13 17:55:04 PDT
JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor The time has come for this buggy custom binding to die! :)
Attachments
patch (47.57 KB, patch)
2009-07-21 19:36 PDT, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2009-07-21 19:36:40 PDT
Created attachment 33235 [details] patch
Sam Weinig
Comment 2 2009-07-21 21:27:57 PDT
Fixed in r46211.
Eric Seidel (no email)
Comment 3 2009-07-22 00:02:43 PDT
Comment on attachment 33235 [details] patch 646 RGBColor* CSSPrimitiveValue::getRGBColorValue(ExceptionCode& ec) const and +RGBColor* SVGColor::rgbColor() const Look like they're leaking, no? They're returning raw pointers to RGBColor object which have a ref count of 1.
Eric Seidel (no email)
Comment 4 2009-07-22 00:03:25 PDT
It seems we eventually want RGBColor to be a wrapper around Color instead of unsigned. That way the red/green/blue/alpha accessors are already written for us (instead of having to re-write the << code.
Eric Seidel (no email)
Comment 5 2009-07-22 00:04:00 PDT
I'm very glad you did this though. I tried and ran into Obj-C issues which I didn't really want to deal with. ;)
Note You need to log in before you can comment on or make changes to this bug.