Bug 272395

Summary: [iOS] fast/writing-mode/english-bt-text-with-spelling-marker.html is a flaky failure after 277233@main
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: ben_schwartz, Morningstar, rackler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Image result before 277233@main none

Wenson Hsieh
Reported 2024-04-09 07:16:50 PDT
.
Attachments
Image result before 277233@main (70.94 KB, image/png)
2024-04-09 07:27 PDT, Wenson Hsieh 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2024-04-09 07:26:05 PDT
From the diff here: https://build.webkit.org/results/Apple-iOS-17-Simulator-Debug-WK2-Tests/277233@main%20(1462)/fast/writing-mode/english-bt-text-with-spelling-marker-diffs.html ...it looks like after 277233@main, there's a tiny difference between the reference and test images.
Wenson Hsieh
Comment 2 2024-04-09 07:27:40 PDT
Created attachment 470839 [details] Image result before 277233@main
Wenson Hsieh
Comment 3 2024-04-09 07:29:40 PDT
Attached an image showing the results (both reference and test) before my fix — there are no spelling dots at all. My change in 277233@main basically made the test start working as intended on iOS 17 (i.e. showing spelling dots). I think we just need to adjust the fuzziness to accommodate.
Wenson Hsieh
Comment 4 2024-04-09 07:39:39 PDT
Pull request: https://github.com/WebKit/WebKit/pull/27029
EWS
Comment 5 2024-04-09 10:55:02 PDT
Committed 277254@main (ef7c999e5c10): <https://commits.webkit.org/277254@main> Reviewed commits have been landed. Closing PR #27029 and removing active labels.
Radar WebKit Bug Importer
Comment 6 2024-04-09 10:56:15 PDT
<rdar://problem/126146299>
Note You need to log in before you can comment on or make changes to this bug.