Bug 272324
| Summary: | [GTK][WPE] Don't request more than a single composition during a layerFlush | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
| Component: | WPE WebKit | Assignee: | Miguel Gomez <magomez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Miguel Gomez
During a layerFlush we're potentially requesting 2 compositions. One comes from the CompositingCoordinator, who will call commitSceneState when the page content has changed and we need to send a new state to the scene. The other one happens unconditionally by the call to m_compositor->updateScene() at the end of the layerflush.
If we request 2 compositions, depending on the situation this can trigger a single composition or two. If two are triggered, we will get more LayerTreeHost::didRenderframe calls than expected, which can prematurely end the state where the LayerTreeHost is waiting for the renderer, causing glitches.
We need to be sure that each layerFlush requests a single composition only.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Miguel Gomez
Pull request: https://github.com/WebKit/WebKit/pull/26970
EWS
Committed 277234@main (1dcc05917fd7): <https://commits.webkit.org/277234@main>
Reviewed commits have been landed. Closing PR #26970 and removing active labels.