Bug 27230

Summary: [Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not declared in this scope
Product: WebKit Reporter: David Ronis <David.Ronis>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: gustavo, jmalonzo
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Use g_mapped_file_unref for GLIB version 2.22 onwards. gustavo: review+

David Ronis
Reported 2009-07-13 12:21:59 PDT
I just tried upgrading webkitgtk+ form 1.1.10 to 1.1.11; I get the compile-time error given in the summary. I'm using gtk+-2.17.2 and the git-master of libsoup (built today). I'm using gcc-4.4.0, on a slackware-12.2. box
Attachments
Use g_mapped_file_unref for GLIB version 2.22 onwards. (1.97 KB, patch)
2009-07-17 19:34 PDT, Jan Alonzo
gustavo: review+
David Ronis
Comment 1 2009-07-13 12:34:02 PDT
Grepped the include dir for the definition: Here's what I see in glib-2.0/glib/gmappedfile.h: #ifndef G_DISABLE_DEPRECATED void g_mapped_file_free (GMappedFile *file); #endif Looks like this is being phased out. In any event, I manually added the declaration to the webkit file and am resuming the compilation.
David Ronis
Comment 2 2009-07-14 07:58:27 PDT
Manually adding the declaration, while allowing thing to compile, doesn't work. Things die linking. Bacially it's not in glib.
David Ronis
Comment 3 2009-07-14 08:09:58 PDT
It seems that g_mapped_file_free needs to be replaced by g_mapped_file_unref. Doing so lets the compile finish.
Jan Alonzo
Comment 4 2009-07-17 19:34:47 PDT
Created attachment 33002 [details] Use g_mapped_file_unref for GLIB version 2.22 onwards.
Gustavo Noronha (kov)
Comment 5 2009-07-18 16:12:46 PDT
Comment on attachment 33002 [details] Use g_mapped_file_unref for GLIB version 2.22 onwards. yep! r=me
Jan Alonzo
Comment 6 2009-07-18 16:14:29 PDT
(In reply to comment #5) > (From update of attachment 33002 [details]) > yep! r=me Landed as http://trac.webkit.org/changeset/46101
Note You need to log in before you can comment on or make changes to this bug.