Bug 27230

Summary: [Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not declared in this scope
Product: WebKit Reporter: David Ronis <David.Ronis@McGill.CA>
Component: WebKit GtkAssignee: Nobody <webkit-unassigned@lists.webkit.org>
Status: RESOLVED FIXED    
Severity: Blocker CC: gns@gnome.org, jmalonzo@gmail.com
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Use g_mapped_file_unref for GLIB version 2.22 onwards. gns: review+

Description From 2009-07-13 12:21:59 PST
I just tried upgrading webkitgtk+ form 1.1.10 to 1.1.11; I get the compile-time error given in the summary.  I'm using gtk+-2.17.2 and the git-master of libsoup (built today).  I'm using gcc-4.4.0, on a slackware-12.2. box
------- Comment #1 From 2009-07-13 12:34:02 PST -------
Grepped the include  dir for the definition: Here's what I see in glib-2.0/glib/gmappedfile.h:


#ifndef G_DISABLE_DEPRECATED
void         g_mapped_file_free         (GMappedFile  *file);
#endif

Looks like this is being phased out.  In any event, I manually added the declaration to the webkit file and am resuming the compilation.
------- Comment #2 From 2009-07-14 07:58:27 PST -------
Manually adding the declaration, while allowing thing to compile, doesn't work.  Things die linking.
Bacially it's not in glib.
------- Comment #3 From 2009-07-14 08:09:58 PST -------
It seems that g_mapped_file_free needs to be replaced by g_mapped_file_unref.  Doing so lets the compile finish.
------- Comment #4 From 2009-07-17 19:34:47 PST -------
Created an attachment (id=33002) [details]
Use g_mapped_file_unref for GLIB version 2.22 onwards.
------- Comment #5 From 2009-07-18 16:12:46 PST -------
(From update of attachment 33002 [details])
yep! r=me
------- Comment #6 From 2009-07-18 16:14:29 PST -------
(In reply to comment #5)
> (From update of attachment 33002 [details] [details])
> yep! r=me

Landed as http://trac.webkit.org/changeset/46101