Bug 271986

Summary:	Add Options::maxHeapSizeAsRAMSizeMultiple() to limit max memory usage for testing.
Product:	WebKit	Reporter:	Mark Lam <mark.lam>
Component:	JavaScriptCore	Assignee:	Mark Lam <mark.lam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Mark Lam

Reported 2024-04-01 12:40:41 PDT

...

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-04-01 12:40:51 PDT

<rdar://problem/125733077>

Mark Lam

Comment 2 2024-04-01 12:47:33 PDT

Currently, we're only applying this max check to CompleteSubspace::tryAllocateSlow. We found that adding it to LocalAllocator::allocateSlowCase can cause crashes due to failed Structure allocations (which are fatal). As a result, the testing disruption from those crashes far outweigh any benefits we currently get from it. So, we'll leave the max check out of LocalAllocator::allocateSlowCase for now.

Mark Lam

Comment 3 2024-04-01 12:50:15 PDT

Pull request: https://github.com/WebKit/WebKit/pull/26691

EWS

Comment 4 2024-04-01 15:35:37 PDT

Committed 276909@main (b682c5819552): <https://commits.webkit.org/276909@main> Reviewed commits have been landed. Closing PR #26691 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.