Bug 271728
| Summary: | [JSC] Redefinitions of RELEASE_ASSERT should be removed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | JavaScriptCore | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Degazio
In:
- AirAllocateRegistersAndStackByLinearScan.cpp
- DFGSSAConversionPhase.cpp
- FTLLowerDFGToB3.cpp
...we redefine the RELEASE_ASSERT macro with pretty much the same implementation, minus the UNLIKELY(...) around the condition and the WTF::isIntegralOrPointerType(...) check. As far as I can tell there's no special reason we need to remove either of these things in these files, so probably we should just use the base RELEASE_ASSERT definition and reduce code duplication.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/125439450>
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/26485
EWS
Committed 276882@main (f62faaf4e133): <https://commits.webkit.org/276882@main>
Reviewed commits have been landed. Closing PR #26485 and removing active labels.