Summary: | [Gtk] REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jan Alonzo <jmalonzo> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | Gtk | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Jan Alonzo
2009-07-10 19:56:31 PDT
Created attachment 32605 [details]
implement grab-focus
Comment on attachment 32605 [details] implement grab-focus > - core(webView)->focusController()->setActive(frame); > - core(webView)->focusController()->setFocused(true); > + focusController->setActive(true); > + focusController->setFocused(true); The only change that makes me a bit nervous is going from frame to true here. I believe there might have been a reason to not set it unconditionally? r=me, but please either revert this specific change, or add a comment here on the bug so that we have a way of tracking this down. (In reply to comment #2) > (From update of attachment 32605 [details]) > > - core(webView)->focusController()->setActive(frame); > > - core(webView)->focusController()->setFocused(true); > > + focusController->setActive(true); > > + focusController->setFocused(true); > > The only change that makes me a bit nervous is going from frame to true here. I > believe there might have been a reason to not set it unconditionally? r=me, but > please either revert this specific change, or add a comment here on the bug so > that we have a way of tracking this down. Thanks. I reverted the change and landed it in http://trac.webkit.org/changeset/45802. |