Bug 271505

Summary:	getCachedWrapper always does HashMap lookup when the wrapper doesn't exist
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Bindings	Assignee:	Ryosuke Niwa <rniwa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Ryosuke Niwa

Reported 2024-03-22 17:28:07 PDT

WebCore::getCachedWrapper always does the HashMap lookup even for objects which inherits from ScriptWrappable for the main world. We should avoid this lookup when an object inherits from ScriptWrappable for the main world.

Attachments
Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2024-03-22 17:32:00 PDT

Pull request: https://github.com/WebKit/WebKit/pull/26355

EWS

Comment 2 2024-03-22 21:31:41 PDT

Committed 276583@main (de25b66294c4): <https://commits.webkit.org/276583@main> Reviewed commits have been landed. Closing PR #26355 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2024-03-22 21:32:13 PDT

<rdar://problem/125277776>

Note You need to log in before you can comment on or make changes to this bug.