Bug 27150

Summary:

REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines into the diff

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mjs

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Print prepare-ChangeLog's reminders to the STDERR so they don't end up in the diff output	mjs: review+

Adam Roben (:aroben)

Reported 2009-07-10 11:05:08 PDT

To reproduce: 1. echo foo >> WebCore/DerivedSources.make 2. prepare-ChangeLog -d WebCore > WebCoreChanges.diff WebCoreChanges.diff will contain the following lines at the beginning: -- Please remember to include a detailed description in your ChangeLog entry. -- -- See <http://webkit.org/coding/contributing.html> for more info -- Those lines should have been printed to the terminal (i.e., STDERR), not into the diff.

Attachments
Print prepare-ChangeLog's reminders to the STDERR so they don't end up in the diff output (1.47 KB, patch) 2009-07-10 11:18 PDT, Adam Roben (:aroben)	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2009-07-10 11:18:11 PDT

Created attachment 32564 [details] Print prepare-ChangeLog's reminders to the STDERR so they don't end up in the diff output

Maciej Stachowiak

Comment 2 2009-07-10 11:48:34 PDT

Comment on attachment 32564 [details] Print prepare-ChangeLog's reminders to the STDERR so they don't end up in the diff output r=me

Adam Roben (:aroben)

Comment 3 2009-07-10 12:19:24 PDT

Fixed in r45718

Note You need to log in before you can comment on or make changes to this bug.