Summary: | JSDebugger crashes after reloading from a breakpoint | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Oliver Hunt <oliver> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, timothy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Oliver Hunt
2009-07-10 01:59:38 PDT
Created attachment 32552 [details]
harden the debugger
Comment on attachment 32552 [details]
harden the debugger
despite fixing the crash weirdness happens in the debugger afterwards
Comment on attachment 32552 [details] harden the debugger Rejecting patch 32552 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=32552 from bug 27146 failed to download and apply. patching file WebCore/inspector/InspectorController.cpp Hunk #1 FAILED at 535. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/inspector/InspectorController.cpp.rej A quick git log search looks like this hasn't been landed yet. Ping? This patch has been chillin-like-a-villin in the to-be-committed list for over a month now. Is the patch still wanted? This was actually fixed by: http://trac.webkit.org/changeset/45733 I don't think this full patch is needed, but I landed the parts that are still relevant. Landed the relevant parts in r49832. |