Bug 271417
| Summary: | [ews] Improve description for upload-file-to-s3 step | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Brianna Fan <bfan2> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Aakash Jain
We should improve description for upload-file-to-s3 step. Currently it says: "Uploaded archive to S3" irrespective of whether it's uploading archive or build logs. It used to be correct since earlier we only used to upload the archives, but since now we also upload logs to S3, this description is no longer accurate. We should fix that.
e.g.: In https://ews-build.webkit.org/#/builders/49/builds/27974 step 15 says "Uploaded archive to S3", while it upload build logs.
It's better to instead print the filename of the file being uploaded.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/125197122>
Brianna Fan
Pull request: https://github.com/WebKit/WebKit/pull/26274
EWS
Committed 276499@main (2410d135f758): <https://commits.webkit.org/276499@main>
Reviewed commits have been landed. Closing PR #26274 and removing active labels.