Bug 271190
| Summary: | Remove unused `width()` and `height()`functions from HTMLDocument (WebKit and WebKitLegacy) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
It seems we dropped them in 2016 from JS exposure and we don't have them in IDL file as of today but we still have C++ code, so I think we should just do the clean-up and get rid of it.
Commit (from 2016 to drop them) - https://github.com/WebKit/WebKit/commit/aabd1dae8c07814a8c27cd98575cf473fc556eac
> Source/WebCore/html/HTMLDocument.cpp:
Delete: HTMLDocument::width()
Delete: HTMLDocument::height()
> Source/WebCore/html/HTMLDocument.h:
WEBCORE_EXPORT int width();
WEBCORE_EXPORT int height();
> Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm:
- (int)width --> return NULL;
- (int)height --> return NULL;
___
Just wanted to raise so we can do the clean-up.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Removed from IDL in - https://commits.webkit.org/179619@main (2016)
Ahmad Saleem
PR - https://github.com/WebKit/WebKit/pull/26082
EWS
Committed 276488@main (9e4d6906a76b): <https://commits.webkit.org/276488@main>
Reviewed commits have been landed. Closing PR #26082 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/125188200>