Bug 271132

Summary: REGRESSION(276246@main): ASSERTION FAILED: contentHasNegativeImplicitMargin
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: ap, bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=271113
Attachments:
Description Flags
WIP patch for fast/text/minimum-width-break-on-empty-content-crash.html none

Fujii Hironori
Reported 2024-03-17 14:07:13 PDT
Only WinCairo is crashing. Regressions: Unexpected crashes (3) fast/text/crash-grapheme-cluster-spanning-adjacent-textitems.html [ Crash ] fast/text/minimum-width-break-on-empty-content-crash.html [ Crash ] fast/text/word-break-column-gap-display-flex-utf16-surrogates.html [ Crash ] History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Ftext%2Fword-break-column-gap-display-flex-utf16-surrogates.html&test=fast%2Ftext%2Fminimum-width-break-on-empty-content-crash.html&test=fast%2Ftext%2Fcrash-grapheme-cluster-spanning-adjacent-textitems.html&platform=wincairo&style=debug https://build.webkit.org/results/WinCairo-64-bit-Debug-Tests/276246@main%20(22114)/fast/text/minimum-width-break-on-empty-content-crash-crash-log.txt ASSERTION FAILED: contentHasNegativeImplicitMargin C:\BW\WinCairo-64-bit-Debug-Build\build\Source\WebCore\layout/formattingContexts/inline/InlineFormattingContext.cpp(201) : minimumMaximumContentSize 1 00007FF8FB3A1CA9 WTFCrash 2 00007FF8D9B32F0D WTFCrashWithInfo 3 00007FF8DD1CFD14 WebCore::Layout::InlineFormattingContext::minimumMaximumContentSize 4 00007FF8DD2BE438 WebCore::LayoutIntegration::LineLayout::computeIntrinsicWidthConstraints 5 00007FF8DDCC2CC4 WebCore::RenderBlockFlow::tryComputePreferredWidthsUsingModernPath 6 00007FF8DDCA9975 WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths 7 00007FF8DDCA96AC WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths 8 00007FF8DDC9EB4E WebCore::RenderBlock::computePreferredLogicalWidths 9 00007FF8DDCCA469 WebCore::RenderBox::maxPreferredLogicalWidth 10 00007FF8DDCC69C3 WebCore::RenderBox::computeLogicalWidthInFragmentUsing 11 00007FF8DDC91941 WebCore::RenderBox::computeLogicalWidthInFragment 12 00007FF8DDCD2250 WebCore::RenderBox::updateLogicalWidth 13 00007FF8DDC8F49A WebCore::RenderBlock::recomputeLogicalWidth 14 00007FF8DDCAB517 WebCore::RenderBlockFlow::recomputeLogicalWidthAndColumnWidth 15 00007FF8DDCAC019 WebCore::RenderBlockFlow::layoutBlock 16 00007FF8DDC8F26E WebCore::RenderBlock::layout 17 00007FF8DDD42C99 WebCore::RenderElement::layoutIfNeeded 18 00007FF8DDCB0CF2 WebCore::RenderBlockFlow::layoutModernLines 19 00007FF8DDCAE766 WebCore::RenderBlockFlow::layoutInlineChildren 20 00007FF8DDCAD5FF WebCore::RenderBlockFlow::layoutInFlowChildren 21 00007FF8DDCAC2FA WebCore::RenderBlockFlow::layoutBlock 22 00007FF8DDC8F26E WebCore::RenderBlock::layout 23 00007FF8DDCAFA03 WebCore::RenderBlockFlow::layoutBlockChild 24 00007FF8DDCAEB4A WebCore::RenderBlockFlow::layoutBlockChildren 25 00007FF8DDCAD63E WebCore::RenderBlockFlow::layoutInFlowChildren 26 00007FF8DDCAC2FA WebCore::RenderBlockFlow::layoutBlock 27 00007FF8DDC8F26E WebCore::RenderBlock::layout 28 00007FF8DDCAFA03 WebCore::RenderBlockFlow::layoutBlockChild 29 00007FF8DDCAEB4A WebCore::RenderBlockFlow::layoutBlockChildren 30 00007FF8DDCAD63E WebCore::RenderBlockFlow::layoutInFlowChildren 31 00007FF8DDCAC2FA WebCore::RenderBlockFlow::layoutBlock
Attachments
WIP patch for fast/text/minimum-width-break-on-empty-content-crash.html (785 bytes, patch)
2024-03-24 18:40 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-03-17 14:11:06 PDT
>Only WinCairo is crashing. this is odd! Let me take a look at those tests.
alan
Comment 2 2024-03-17 14:24:13 PDT
Didn't see anything peculiar. It'd be interesting to find out what else triggers inconsistent min/max results on WinCairo -maybe we just need fuzzy matching?
Radar WebKit Bug Importer
Comment 3 2024-03-24 14:08:08 PDT
<rdar://problem/125322599>
Fujii Hironori
Comment 4 2024-03-24 18:40:17 PDT
Created attachment 470585 [details] WIP patch for fast/text/minimum-width-break-on-empty-content-crash.html For fast/text/minimum-width-break-on-empty-content-crash.html, Font::widthForGlyph of "\n" glyph returns 6 on Windows. This is a width of the space glyph. It should be 0.
Fujii Hironori
Comment 5 2024-03-28 16:05:58 PDT
276774@main fixed fast/text/minimum-width-break-on-empty-content-crash.html problem. 276797@main fixed fast/text/word-break-column-gap-display-flex-utf16-surrogates.html problem. fast/text/crash-grapheme-cluster-spanning-adjacent-textitems.html is still crashing for Windows port.
Note You need to log in before you can comment on or make changes to this bug.