Bug 271074
| Summary: | [UnifiedPDF] Data detector page overlay tiles should not be repainted when there is no active highlight | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Abrar Rahman Protyasha <a_protyasha> |
| Component: | Assignee: | Abrar Rahman Protyasha <a_protyasha> | |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | a_protyasha, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Abrar Rahman Protyasha
Currently, we unconditionally call PageOverlay::setNeedsDisplay() whenever we scroll the PDF plugin. This is incredibly inefficient because we're repainting all the tiles even when there is no need to repaint. Let's be more prudent and teach the data detector overlay controller to better reason about when a repaint is necessary.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/124707729>
Abrar Rahman Protyasha
Pull request: https://github.com/WebKit/WebKit/pull/25965
EWS
Committed 276200@main (3aad301970ab): <https://commits.webkit.org/276200@main>
Reviewed commits have been landed. Closing PR #25965 and removing active labels.