Bug 271055
| Summary: | [Xcode] Simplify code coverage builds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=244540 | ||
| Bug Depends on: | 206686 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
Simplify code coverage builds when using Xcode.
Instead of specifying a path to Tools/coverage/coverage.xcconfig when building, use the CLANG_COVERAGE_MAPPING=YES Xcode variable to enable code coverage.
This does the exact same thing as the prior contents of coverage.xcconfig, but Xcode "knows" that code coverage is enabled and can make better choices about interactions with other compiler settings.
Note that compiling $WEBKIT_BUILD/Release/DerivedSources/WebCore/InternalSettingsGenerated.cpp with code coverage enables causes clang to hang indefinitely (tracked by <rdar://124640196>), so COMPILER_FLAGS="-fno-profile-instr-generate -fno-coverage-mapping" is set for that one source file until this is fixed.
<rdar://124086420>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/25944
EWS
Committed 276273@main (ee7e9fa11501): <https://commits.webkit.org/276273@main>
Reviewed commits have been landed. Closing PR #25944 and removing active labels.