Bug 270993
| Summary: | Assertion failure in pas_enumerator_create due to wrong alignment | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | bmalloc | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Degazio
rdar://124562475
We recently bumped the PAS_INTERNAL_MIN_ALIGNMENT from 8 to 16 bytes. Most of libPAS respects this constant and hasn't had any issues in our normal testing, but it looks like pas_enumerator_create runs into a novel assertion failure. Specifically, a pas_enumerator_region consists of a 24-byte prefix before a payload, and we expect the payload to be aligned to the internal minimum - which 24 bytes doesn't satisfy. We should explicitly specify this alignment requirement in the pas_enumerator_region type so we no longer run into this assertion failure.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/25894
EWS
Committed 276187@main (5aa139649dd7): <https://commits.webkit.org/276187@main>
Reviewed commits have been landed. Closing PR #25894 and removing active labels.