Bug 27094

Summary: [Chromium] Upstream V8 npruntime bindings
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch2 dglazkov: review+

Nate Chapin
Reported 2009-07-08 14:22:10 PDT
See summary.
Attachments
patch (24.08 KB, patch)
2009-07-08 14:25 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
patch2 (24.09 KB, patch)
2009-07-08 14:33 PDT, Nate Chapin 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2009-07-08 14:25:27 PDT
Created attachment 32473 [details] patch
Nate Chapin
Comment 2 2009-07-08 14:33:04 PDT
Created attachment 32474 [details] patch2
Dimitri Glazkov (Google)
Comment 3 2009-07-08 14:42:05 PDT
Comment on attachment 32474 [details] patch2 r=me, with nits: > +// Commenting out the locks to avoid dependencies on chrome for now. > +// Need a platform abstraction which we can use. > +// static Lock StringIdentifierMapLock; > + Remove commented code. > +// FIXME: Consider removing locks if we're singlethreaded already. > +// static Lock IntIdentifierMapLock; Ditto. > + // AutoLock safeLock(StringIdentifierMapLock); Ditto. > + // AutoLock safeLock(IntIdentifierMapLock); Ditto.
Nate Chapin
Comment 4 2009-07-08 14:51:55 PDT
Landed as r45641.
Note You need to log in before you can comment on or make changes to this bug.