Bug 270849
Summary: | [WPE] Fix text highlight on HTTP RWI running on Chromium | ||
---|---|---|---|
Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
Component: | Web Inspector | Assignee: | Miguel Gomez <magomez> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Miguel Gomez
Text highlighting is not working when the HTTP RWI is run on Chrome or Chromium.
This can be reproduced by opening the HTTP RWI on Chromium or Chrome, going to the Sources tab and adding a breakpoint in some line. Clicking on the breakpoint on the left side bar should scroll the file content to the line where the breakpoint is, and create a highlight animation effect on the line. But, while the scrolling works, the animation effect is not shown.
This is caused because the relevant css declarations are setting the animation names inside quotes, which works on WebKit but doesn't work on Chrome. We should remove the quotes as they are not meant to be used there.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Miguel Gomez
Pull request: https://github.com/WebKit/WebKit/pull/25772
EWS
Committed 276081@main (d1ce25eca8a3): <https://commits.webkit.org/276081@main>
Reviewed commits have been landed. Closing PR #25772 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/124605865>