Bug 270776
| Summary: | [Skia] libSkia.a is always considered outdated | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick Griffis <pgriffis> |
| Component: | WPE WebKit | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aperez, bugs-noreply, webkit-bug-importer |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=273315 | ||
| Bug Depends on: | |||
| Bug Blocks: | 268972 | ||
Patrick Griffis
If you run: `ninja -d explain -C WebKitBuild/WPE/Debug libSkia.a`
It outputs:
ninja explain: output Source/ThirdParty/skia/CMakeFiles/Skia_headers_symlink doesn't exist
ninja explain: Source/ThirdParty/skia/CMakeFiles/Skia_headers_symlink is dirty
ninja explain: Skia/Headers/skia is dirty
[1/1] Link Skia headers
This causes every single build to relink Skia and everything that depends on it.
Currently this is defined in CMake as:
add_custom_target(Skia_headers_symlink
COMMAND ${CMAKE_COMMAND} -E create_symlink
"${CMAKE_CURRENT_SOURCE_DIR}/include"
"${Skia_FRAMEWORK_HEADERS_DIR}/skia"
BYPRODUCTS
"${Skia_FRAMEWORK_HEADERS_DIR}/skia"
COMMENT "Link Skia headers"
)
add_dependencies(Skia Skia_headers_symlink)
I'm not sure what the proper solution to this is.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
I think we may be able to use a POST_BUILD custom command to generate the
symlink after libSkia.a is built *without* having the build system consider
that the library is always outdated. Let me give it a try.
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/27620
EWS
Committed 277860@main (c48d5a8a6a38): <https://commits.webkit.org/277860@main>
Reviewed commits have been landed. Closing PR #27620 and removing active labels.