Bug 270731

Summary:

[RenderTreeDump] Use linesBoundingBox for text, line break and inline box

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

Diego Pino <dpino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jbedard, jer.noble, koivisto, kondapallykalyan, Morningstar, pdr, philipj, philn, sergio, simon.fraser, webkit-bug-importer, youssefdevelops, y_soliman, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
[fast-cq]Patch	none
[fast-cq]Patch	none

alan

Reported 2024-03-08 20:27:22 PST

ssia

Attachments
Patch (4.40 KB, patch) 2024-03-08 20:30 PST, alan	no flags	Details Formatted Diff Diff
Patch (4.63 MB, patch) 2024-03-09 06:14 PST, alan	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.33 MB, patch) 2024-03-09 08:30 PST, alan	no flags	Details Formatted Diff Diff
Patch (8.36 MB, patch) 2024-03-09 08:55 PST, alan	no flags	Details Formatted Diff Diff
Patch (8.60 MB, patch) 2024-03-09 10:23 PST, alan	no flags	Details Formatted Diff Diff
Patch (8.60 MB, patch) 2024-03-09 12:22 PST, alan	no flags	Details Formatted Diff Diff
Patch (8.70 MB, patch) 2024-03-09 15:41 PST, alan	no flags	Details Formatted Diff Diff
Patch (8.70 MB, patch) 2024-03-09 17:17 PST, alan	no flags	Details Formatted Diff Diff
Patch (8.70 MB, patch) 2024-03-09 19:20 PST, alan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (8.71 MB, patch) 2024-03-09 20:48 PST, alan	no flags	Details Formatted Diff Diff
[fast-cq]Patch (4.51 KB, patch) 2024-03-12 16:02 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2024-03-08 20:30:13 PST

Created attachment 470256 [details] Patch

alan

Comment 2 2024-03-09 06:14:52 PST

Created attachment 470263 [details] Patch

alan

Comment 3 2024-03-09 08:30:24 PST

Created attachment 470264 [details] Patch

alan

Comment 4 2024-03-09 08:55:46 PST

Created attachment 470265 [details] Patch

alan

Comment 5 2024-03-09 10:23:26 PST

Created attachment 470267 [details] Patch

alan

Comment 6 2024-03-09 12:22:19 PST

Created attachment 470268 [details] Patch

alan

Comment 7 2024-03-09 15:41:50 PST

Created attachment 470269 [details] Patch

alan

Comment 8 2024-03-09 17:17:17 PST

Created attachment 470270 [details] Patch

alan

Comment 9 2024-03-09 19:20:47 PST

Created attachment 470271 [details] Patch

alan

Comment 10 2024-03-09 20:48:38 PST

Created attachment 470273 [details] [fast-cq]Patch

EWS

Comment 11 2024-03-09 20:56:06 PST

Committed 275888@main (d1c4d862ad1b): <https://commits.webkit.org/275888@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470273 [details].

Radar WebKit Bug Importer

Comment 12 2024-03-09 20:57:22 PST

<rdar://problem/124342719>

Philippe Normand

Comment 13 2024-03-10 01:46:50 PST

Second time in 3 days a massive rebaseline is needed... Can you coordinate with other ports next time please?

alan

Comment 14 2024-03-10 06:26:17 PDT

(In reply to Philippe Normand from comment #13) > Second time in 3 days a massive rebaseline is needed... Can you coordinate > with other ports next time please? Most certainly. Do you think a heads-up at #webkit slack will suffice or you have something else in your mind?

Philippe Normand

Comment 15 2024-03-10 08:03:37 PDT

Heads-up in slack's #dev channel would be nice yeah, mentioning at least one Igalia folks (dpino, vitaly, csaavedra or myself).

alan

Comment 16 2024-03-10 08:10:15 PDT

(In reply to Philippe Normand from comment #15) > Heads-up in slack's #dev channel would be nice yeah, mentioning at least one > Igalia folks (dpino, vitaly, csaavedra or myself). ok, I'll do that next time. thanks for letting me know and sorry for the trouble!

Diego Pino

Comment 17 2024-03-12 13:32:16 PDT

Re-opening for pull request https://github.com/webkit/webkit/pull/25788

EWS

Comment 18 2024-03-12 13:47:31 PDT

Committed 275995@main (899b2d18cda7): <https://commits.webkit.org/275995@main> Reviewed commits have been landed. Closing PR #25788 and removing active labels.

Dawn Morningstar

Comment 19 2024-03-12 15:35:45 PDT

Another couple tests were missed from this change on iOS: fast/block/basic/001.html imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual.svg HISTORY: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Fblock%2Fbasic%2F001.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fsvg%2Ftext%2Fvisualtests%2Ftext-inline-size-003-visual.svg

alan

Comment 20 2024-03-12 15:49:12 PDT

(In reply to Dawn Morningstar from comment #19) > Another couple tests were missed from this change on iOS: > fast/block/basic/001.html > imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003- > visual.svg > > HISTORY: > https://results.webkit.org/?suite=layout-tests&suite=layout- > tests&test=fast%2Fblock%2Fbasic%2F001.html&test=imported%2Fw3c%2Fweb- > platform-tests%2Fsvg%2Ftext%2Fvisualtests%2Ftext-inline-size-003-visual.svg Thank you. Let me take care of it.

alan

Comment 21 2024-03-12 16:02:04 PDT

Reopening to attach new patch.

alan

Comment 22 2024-03-12 16:02:07 PDT

Created attachment 470326 [details] [fast-cq]Patch

EWS

Comment 23 2024-03-12 16:09:52 PDT

Committed 276004@main (09186d9fddd9): <https://commits.webkit.org/276004@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470326 [details].

EWS

Comment 24 2024-03-14 09:30:45 PDT

Test gardening commit 276098@main (d43c60471f20): <https://commits.webkit.org/276098@main> Reviewed commits have been landed. Closing PR #25876 and removing active labels.

EWS

Comment 25 2024-03-19 03:40:40 PDT

Test gardening commit 276340@main (b70de8cb2627): <https://commits.webkit.org/276340@main> Reviewed commits have been landed. Closing PR #26051 and removing active labels.

EWS

Comment 26 2024-03-21 10:50:02 PDT

Test gardening commit 276476@main (95c922e162bb): <https://commits.webkit.org/276476@main> Reviewed commits have been landed. Closing PR #26182 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.