Bug 27059

Summary: Exclude Symbian platform from define of MIDDLE_ENDIAN
Product: WebKit Reporter: Norbert Leser <norbert.leser>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: abarth, eric, hausmann, laszlo.gombos, mjs, yongjun.zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Description Flags
Code patch for Platform.h
eric: review-
Update of patch file for bug #27059
2nd update of patch file for bug #27059
3rd update of patch file for bug #27059 abarth: commit-queue+

Description Norbert Leser 2009-07-07 19:18:11 PDT
Created attachment 32418 [details]
Code patch for Platform.h

The proposed patch adds !PLATFORM(SYMBIAN) tpo prevent it from entering the conditional code block that defines WTF_PLATFORM_MIDDLE_ENDIAN=1.
Comment 1 Eric Seidel (no email) 2009-07-10 23:17:06 PDT
Comment on attachment 32418 [details]
Code patch for Platform.h

Why?  PLATFORM(SYMBIAN) seems the wrong level of define to be using here.
Comment 2 Norbert Leser 2009-08-05 15:00:06 PDT
Created attachment 34180 [details]
Update of patch file for bug #27059

I updated the patch according to the review comment.

Instead of adding a !SYMBIAN condition to the already hard to decipher 
negative conditional clause within the ARM block,
I added the proper __ARM_EABI__ flag to the SYMBIAN case.

In addition, I cleaned up the condition of the else branch in the ARM block
(removed redundant condition check).
Comment 3 Darin Adler 2009-08-05 16:45:11 PDT
Comment on attachment 34180 [details]
Update of patch file for bug #27059

Seems unfortunate to define something that begins with two underscores, since that's supposed to be reserved for the environment, not the library.
Comment 4 Norbert Leser 2009-08-06 10:32:09 PDT
Created attachment 34212 [details]
2nd update of patch file for bug #27059

I agree with Darin'd comment of trying to avoid redefining variables with beginning double underscores in the library code.

How about this updated patch:
Since on Symbian, we detect the __EABI__ variable but not __ARM_EABI__, I simply added that flag to the respective (negative) conditional statements.
It's only in 2 places and I assume it is safe for any other platforms that may or may not have this flag set.
Comment 5 Norbert Leser 2009-08-06 11:58:35 PDT
Created attachment 34216 [details]
3rd update of patch file for bug #27059

Fixed a typo (superfluous spaces) - otherwise same as patch platform_h_bug_27059_3.txt
Comment 6 Adam Barth 2009-08-06 21:11:09 PDT
Comment on attachment 34216 [details]
3rd update of patch file for bug #27059

Clearing review flag on attachment: 34216

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/Platform.h
Committed r46881
	M	JavaScriptCore/wtf/Platform.h
	M	JavaScriptCore/ChangeLog
r46881 = 5dc259f3deb7d16009ef6a9c9d0573db54f74cc4 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
Comment 7 Adam Barth 2009-08-06 21:11:14 PDT
All reviewed patches have been landed.  Closing bug.