| Summary: | Wrong time Total in Resources -> Time | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | hauk | ||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED INVALID | ||||||||||
| Severity: | Normal | CC: | caseq, eric, joepeck, pfeldman | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
hauk
2009-07-07 13:42:07 PDT
Created attachment 32390 [details]
Resources/Time
This is apparently still happening. A good test page for me is: http://about.validator.nu/ It takes me about 30 seconds to load that page, and the results are slightly off. Toggle between "Sum" and "Total" by clicking. http://screencast.com/t/VLEWRS8ER Created attachment 33956 [details]
Toggle Showing "Sum" or "Total"
This current behavior is actually correct, but it may not be what the user may initially think:
Time = Total Time it took for the page to load. Note that resources may have been downloaded in parallel or there may have been spans of time where no downloading/requests were sent.
Sum = The Sum of Each of the Categories listed at the top.
Clicking on the legend will alternate between them. By toggling a setting it makes it so as the Resources view continually refreshes it will continue to show whichever the user was showing last. (This is not a permanent setting).
Yes, when the result is presented with such a heading: Documents Stylesheets Images ... Total It is natural to assume that Total is the total sum of all the elements in the list. If Total also includes other stuff such as IO wait and processing time etc. not in the list, it would be better IMHO to include this in Other so that adding up all elements in the list actually is Total. We could default to Sum and make click show Total. Hmm, would there be any objection to showing the Sum and the Total? Would it be too wide? Let me upload a Screenshot of what it would look like. Created attachment 33980 [details]
Showing Both Labels Versus Showing One
Showing Both labels does make it prone to horizontal scrolling (scrollbar will appear). So it may be a good idea to keep this toggle on click.
I guess we should just show Sum up there. Both make it too long. And we already show the Total in the graph header. I second that Sum is the right thing in this context. As a user, looking at time I am only interested in the load/render time of each element in the page and the total time. The time used internal by the processing machinery in webkit is of no relevance for a user who use this view to e.g. investigate what can be optimized. Hauk, what do you think about this problem: As a user, if you see that the Sum says "10s" but the graph only ranges from "0s to 6s", what would you think? This could actually happen if there is enough parallelization (or overlap) of downloading resources. Could we make this clearer? That was the original reason we used the number we did for Total. Due to parallelization a sum might give the impression a page is slower than it really was. This isn't about time spent in WebKit processing or rendering, that data isn't part of this graph. I would like to show how much time was saved with parallelization (total time that did overlap). Ideas for displaying the time saved? How about for the Sum show "10.34s (1.51s)" which would prompt the user to check for a tooltip. The tooltip would then clarify that (1.51s) was how much time was saved via overlap/parallelization. Or alternatively the Sum would show "10.34s (8.83s)" where the tooltip would say "8.83s is the total time, in which 1.51s was saved due to overlap/parallelization. Is this patch ready to commit? Comment on attachment 33956 [details]
Toggle Showing "Sum" or "Total"
I think the design is still being discussed. Removing the regive flag for now.
Hmm, I took the approach where the "Sum" contains the "sumTime (totalTime)" with a tooltip and it looks okay: http://bogojoker.com/snaps/tooltip.png That is, until a late AJAX Request is made. Then I don't really know what to display, because the totalTime will certainly be more then the Sum (in which case I hide the totalTime and tooltip). Still, not the best. I'll see if I can come up with something more appropriate. Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk. |
