Bug 270384 – REGRESSION(275551@main): 3X API-Tests broke across all testing queues, 15X Layout-tests are now broken on site-isolation queues

• Component: WebKit Process Model
• Status: RESOLVED FIXED

[Robert Jenner]

The following 3X API test are broken across all queues, and the following 15X layout-tests are broken, but ONLY on the site-isolation queue:

API-tests:
TestWebKitAPI.ProcessSwap.ConcurrentHistoryNavigations ( Flaky Timeout, Failure, and Pass on iOS 17, and macOS Monterey and higher)
TestWebKitAPI.ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted (Constant crash on Debug for iOS17, and macOS Monterey and higher)
TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON (Constant crash on Debug for iOS17, and macOS Monterey and higher)

HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.ProcessSwap.ConcurrentHistoryNavigations&test=TestWebKitAPI.ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted&test=TestWebKitAPI.ProcessSwap.QuickBackForwardNavigationWithPSON

Both API-tests that are crashing are hitting the same assertion, which is the following:
ASSERTION FAILED: !users.contains(pageID)
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/Source/WebKit/UIProcess/WebProcessProxy.cpp(880) : void 

Layout-Tests:
http/tests/inspector/target/provisional-load-cancels-previous-load.html (Constant Timeout)
http/tests/inspector/target/target-events-for-provisional-page.html (Constant Timeout)
http/tests/media/media-stream/get-user-media-localhost.html (Constant Timeout)
http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html (Constant Timeout)
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral.html (Constant Timeout)
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html ( Constant Crash)
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html (Constant Timeout)
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority.html (Constant Timeout)
http/tests/privateClickMeasurement/clear-through-website-data-removal.html (Constant Timeout)
http/tests/privateClickMeasurement/expired-ad-click-gets-removed-on-session-start.html (Constant Timeout)
http/tests/privateClickMeasurement/expired-attributions-removed.html (Constant Timeout)
http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-fragment-from-prevalent-resource.html (Constant Timeout)
http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-and-fragment-from-prevalent-resource.html (Constant Timeout)
http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-with-link-query-from-prevalent-resource.html (Constant Timeout)
imported/w3c/web-platform-tests/fetch/http-cache/status.any.html (Constant Timeout)


The one test that is crashing "http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html" is hitting the following assertion:
ASSERTION FAILED: !m_messageReceivers.contains(std::make_pair(messageReceiverName, destinationID))
/Volumes/Data/worker/Apple-Sonoma-Debug-Build/build/Source/WebKit/Platform/IPC/MessageReceiverMap.cpp(53) : void IPC::MessageReceiverMap::addMessageReceiver(ReceiverName, uint64_t, MessageReceiver &)

https://build.webkit.org/results/Apple-Sonoma-Debug-WK2-Site-Isolation-Tree-Tests/275551@main%20(937)/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-crash-log.txt


HISTORY:
https://results.webkit.org/?flavor=site-isolation&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Finspector%2Ftarget%2Fprovisional-load-cancels-previous-load.html&test=http%2Ftests%2Finspector%2Ftarget%2Ftarget-events-for-provisional-page.html&test=http%2Ftests%2Fmedia%2Fmedia-stream%2Fget-user-media-localhost.html&test=http%2Ftests%2FprivateClickMeasurement%2Fattribution-conversion-through-fetch-keepalive.html&test=http%2Ftests%2FprivateClickMeasurement%2Fattribution-conversion-through-image-redirect-ephemeral.html&test=http%2Ftests%2FprivateClickMeasurement%2Fattribution-conversion-through-image-redirect-in-new-window.html&test=http%2Ftests%2FprivateClickMeasurement%2Fattribution-conversion-through-image-redirect-with-priority.html&test=http%2Ftests%2FprivateClickMeasurement%2Fattribution-conversion-through-image-redirect-without-priority.html&test=http%2Ftests%2FprivateClickMeasurement%2Fclear-through-website-data-removal.html&test=http%2Ftests%2FprivateClickMeasurement%2Fexpired-ad-click-gets-removed-on-session-start.html&test=http%2Ftests%2FprivateClickMeasurement%2Fexpired-attributions-removed.html&test=http%2Ftests%2FresourceLoadStatistics%2Fcapped-lifetime-for-cookie-set-in-js-with-link-fragment-from-prevalent-resource.html&test=http%2Ftests%2FresourceLoadStatistics%2Fcapped-lifetime-for-cookie-set-in-js-with-link-query-and-fragment-from-prevalent-resource.html&test=http%2Ftests%2FresourceLoadStatistics%2Fcapped-lifetime-for-cookie-set-in-js-with-link-query-from-prevalent-resource.html&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fhttp-cache%2Fstatus.any.html

[Robert Jenner]

I validated that 275551@main is the regression point for the API-tests. They all broke at that point, but were passing on 275550@main. 

As for the layout-tests I also verified that those all started to fail at 275551@main, and were passing at 275550@main. But this is ONLY on the site-isolation queue.

[Radar WebKit Bug Importer]

<rdar://problem/123925831>

[EWS]

Committed 275585@main (91462164b131): <https://commits.webkit.org/275585@main>

Reviewed commits have been landed. Closing PR #25371 and removing active labels.