Bug 270320
| Summary: | Simplify use of sendWithPromisedReplyOnDispatcher | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | WebKit2 | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 270282 | ||
| Bug Blocks: | |||
Jean-Yves Avenard [:jya]
When using sendWithPromisedReplyOnDispatcher you need to specify the WorkQueue twice like so:
`connection.sendWithPromisedReplyOnDispatcher(message, workqueue)->whenSettled(workqueue, [] { })`
the first SerialFunctionDispatcher is used to determined with the Message's IPC Decoder needs to run and the 2nd on where the callback will run.
The 1st SerialFunctionDispatcher should be able to be deducted from the second.
This can now be achieved easily following bug 270282.
and so you could write:
`connection.sendWithPromisedReply(message)->whenSettled(workqueue, [] { })`
The decoder would be automatically first dispatched when a completion handler is attached to the promise.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/123857833>
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/25335
EWS
Committed 275764@main (bb6155442858): <https://commits.webkit.org/275764@main>
Reviewed commits have been landed. Closing PR #25335 and removing active labels.