Bug 270276

Summary: AX: VoiceOver reads erroneous value for datetime-local input elements.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cdumez, cfleizach, changseok, dmazzoni, esprehn+autocc, ews-watchlist, gyuyoung.kim, jcraig, mifenton, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Andres Gonzalez
Reported 2024-02-28 19:31:55 PST
.
Attachments
Patch (13.60 KB, patch)
2024-02-28 19:46 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (16.31 KB, patch)
2024-02-29 06:12 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (17.28 KB, patch)
2024-02-29 12:37 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-02-28 19:32:08 PST
<rdar://problem/123803281>
Andres Gonzalez
Comment 2 2024-02-28 19:46:44 PST
Created attachment 470090 [details] Patch
Tyler Wilcock
Comment 3 2024-02-28 20:28:01 PST
Comment on attachment 470090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=470090&action=review > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:921 > + auto description = descriptionOfValue(value.get()); > + if (description) > + return concatenateAttributeAndValue(@"AXDateValue", description.get()); Can this be: if (auto description = descriptionOfValue(value.get())) return concatenateAttributeAndValue(@"AXDateValue", description.get());
Andres Gonzalez
Comment 4 2024-02-29 06:12:05 PST
Created attachment 470092 [details] Patch
Andres Gonzalez
Comment 5 2024-02-29 06:31:48 PST
(In reply to Tyler Wilcock from comment #3) > Comment on attachment 470090 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=470090&action=review > > > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:921 > > + auto description = descriptionOfValue(value.get()); > > + if (description) > > + return concatenateAttributeAndValue(@"AXDateValue", description.get()); > > Can this be: > > if (auto description = descriptionOfValue(value.get())) > return concatenateAttributeAndValue(@"AXDateValue", description.get()); Fixed, thanks.
Andres Gonzalez
Comment 6 2024-02-29 12:37:15 PST
Created attachment 470103 [details] Patch
EWS
Comment 7 2024-03-01 05:20:57 PST
Committed 275548@main (1377080ff3c3): <https://commits.webkit.org/275548@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470103 [details].
Note You need to log in before you can comment on or make changes to this bug.